| 30 Dec 2023 |
 chr1sno | for example | 13:18:40 |
 k1_801 | Probably hidapi's codestyle settings | 13:18:52 |
| chr1sno | did you want tto make a comment on the issue to get them to test it? | 13:19:23 |
| chr1sno | * did you want to make a comment on the issue to get them to test it? | 13:19:28 |
| k1_801 | Not to mention a failed pipeline | 15:22:31 |
| k1_801 | * Not to mention a failed pipeline
I see no errors in the output, though. | 15:23:56 |
|  @jopejoe1:matrix.org changed their display name from jopejoe1 [4094] to jopejoe1. | 22:05:02 |
| 1 Jan 2024 |
| k1_801 | didn't work :( | 18:21:42 |
| k1_801 | * didn't work :(
I am running out of ideas. | 18:36:59 |
|  algfree changed their profile picture. | 21:17:17 |
| chr1sno | Ok, then perhaps we need to diagnose the issue. Should we modify the code to save the corrupt save before creating the new one. Then we can investigate the problem? | 23:12:27 |
| chr1sno | * Ok, then perhaps we need to diagnose the issue. Should we modify the code to save the corrupt save before creating the new one. Then we can investigate the problem? | 23:12:33 |
| 2 Jan 2024 |
| k1_801 | Going to write a prototype that does just that (back up the config file upon the first successful load and back up the corrupted config file upon the failed attempt for further inspection). But, if I'm reading the error correctly, it's just going to be empty. | 01:59:55 |
 calcprogrammer1 | is this something we can implement with a plugin API change? | 19:15:48 |
 morg7672 | its not related to plugin API | 19:15:58 |
| morg7672 | it breaks the plugins state, symbol resolving | 19:16:11 |
| calcprogrammer1 | the goal of that change was to allow plugins to be removed at runtime, is this not doable at all? | 19:16:25 |
| morg7672 | icons are messed up, some plugins segfaults on qt calls | 19:16:28 |
| calcprogrammer1 | hmm | 19:16:36 |
| morg7672 | i guess this change was not tested at all | 19:16:39 |
| calcprogrammer1 | I can revert it | 19:16:58 |
| morg7672 | please | 19:17:03 |
| morg7672 | we clearly have to fix the plugin removal, but this one breaks the plugin load | 19:17:23 |
| morg7672 | pinging sir_qwex here as he's the author | 19:19:20 |
| morg7672 | let's open a thread if needed | 19:19:31 |
| calcprogrammer1 | https://gitlab.com/CalcProgrammer1/OpenRGB/-/merge_requests/2209 | 19:19:45 |
| morg7672 | https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3822 | 19:20:32 |
 sir_qwex | I tested it with effectengine and the fancontroller plugin and for me it's worked and I could remove the plugin in runtime.
Could the crash be OS related? I am using windows. | 19:33:14 |
| morg7672 | yes maybe os related, tested on linux, breaks a few plugins | 19:33:43 |
| morg7672 | either in debug or release | 19:34:02 |
