!ChuQQIVJvwyJujhNIG:synapse.keyvan.pw

Matrix Puppet Bridge

606 Members
https://github.com/matrix-hacks/matrix-puppet-bridge285 Servers

Load older messages


SenderMessageTime
26 Mar 2017
@erdnaxeli:cervoi.seerdnaxeli I think it's ok
21:41:56
@erdnaxeli:cervoi.seerdnaxeli in handleThirdPartyRoomMessage, we check if the message is tagged only if senderId is undefined 21:42:25
@erdnaxeli:cervoi.seerdnaxeliso if A and B have each a bridge, the messages sent from A will not be checked on the B bridge and will be display correctly21:43:03
@kfatehi:synapse.keyvan.pwkfatehi makes sense. that check is missing in handleThirdPartyRoomImageMessage 21:41:33
@kfatehi:synapse.keyvan.pwkfatehihow are you not getting dupes. maybe im missing something21:41:59
@erdnaxeli:cervoi.seerdnaxelihmm, good question :D21:44:41
@kfatehi:synapse.keyvan.pwkfatehilol. ok so i will just move the tag check (+filename checking) into that method and we should be ok21:42:56
@kfatehi:synapse.keyvan.pwkfatehii mean add, not move21:43:26
@kfatehi:synapse.keyvan.pwkfatehithe solution worked by the way. funny enough :)21:43:45
@erdnaxeli:cervoi.seerdnaxeli

ok so here is what happens when I send an image from matrix:

  • we send a text message with the filename (tagged): ok, dedup works
  • we send the image: it comes back as a share type, which is not handled for now
21:47:37
@erdnaxeli:cervoi.seerdnaxeliso it's just luck :p21:47:46
@kfatehi:synapse.keyvan.pwkfatehicool Shmavery just merged my PR adding the link to matrix-puppet-facebook to facebook-chat-api's README21:45:26
@erdnaxeli:cervoi.seerdnaxelinice o/21:48:11
@kfatehi:synapse.keyvan.pwkfatehioh LOL ok got you21:45:58
@erdnaxeli:cervoi.seerdnaxelion another subject: do you know if an appservice receive the read events?21:50:06
@erdnaxeli:cervoi.seerdnaxeli i've put an info(data) on handleMatrixEvent and I don't see any read event :( 21:50:53
@erdnaxeli:cervoi.seerdnaxelithis is not good21:50:59
@kfatehi:synapse.keyvan.pwkfatehii haven't looked into that yet, sorry21:49:06
@erdnaxeli:cervoi.seerdnaxelithe spec is not really clear about which event are forwarded or not the an appservice21:52:10
@erdnaxeli:cervoi.seerdnaxeliI will just wait for an answer on #bridges:matrix.org21:52:45
@kfatehi:synapse.keyvan.pwkfatehiha! your solution worked. thanks erdnaxeli22:05:50
@kfatehi:synapse.keyvan.pwkfatehifeels magical.22:09:00
@kfatehi:synapse.keyvan.pwkfatehigoing to merge and cutting new releases now. hey does anyone else use the imessage bridge or is it just Andy and I ?22:09:26
@bot:synapse.keyvan.pwGoNEB! [matrix-hacks/matrix-puppet-imessage] kfatehi pushed 3 commits to master: https://github.com/matrix-hacks/matrix-puppet-imessage/commit/2e31124e4a23f0e5e5567bdfc881e93d74c354f6
kfatehi: bidirectional images! dupes when sent from matrix
kfatehi: tag filenames, fix an interface change
kfatehi: bump versions
22:11:17
@bot:synapse.keyvan.pwGoNEB! [matrix-hacks/matrix-puppet-bridge] kfatehi pushed to master: add filename tag util, check tags on inbound image - https://github.com/matrix-hacks/matrix-puppet-bridge/commit/4fcc70814989cab00c6175f2d0da94d1de2939ea 22:12:31
@bot:synapse.keyvan.pwGoNEB! [matrix-hacks/matrix-puppet-bridge] kfatehi pushed to refs/tags/v1.13.0: add filename tag util, check tags on inbound image - https://github.com/matrix-hacks/matrix-puppet-bridge/commit/4fcc70814989cab00c6175f2d0da94d1de2939ea 22:12:31
@kfatehi:synapse.keyvan.pwkfatehimatrix-puppet-bridge v1.13.0 published to npm. major changes are bidirectional image support, and contact list room (as utilized by respective bridge apps)22:14:02
@kfatehi:synapse.keyvan.pwkfatehianother improvement is that more promise-chains are caught into the status room. if anyone notices an error that doesn't go into the status room with a nice error message, make an issue about it because it's a bug.22:16:27
@bot:synapse.keyvan.pwGoNEB! [matrix-hacks/matrix-puppet-bridge] kfatehi closed issue #4: feature: special bridge room with user list [closed] - https://github.com/matrix-hacks/matrix-puppet-bridge/issues/4 22:17:24
@bot:synapse.keyvan.pwGoNEB! [matrix-hacks/matrix-puppet-imessage] kfatehi closed issue #11: Forward images from iMessage->Matrix [closed] - https://github.com/matrix-hacks/matrix-puppet-imessage/issues/11 22:17:44

There are no newer messages yet.


Back to Room ListRoom Version: