| 26 Mar 2017 |
 erdnaxeli | I think it's ok
| 21:41:56 |
| erdnaxeli | in handleThirdPartyRoomMessage, we check if the message is tagged only if senderId is undefined | 21:42:25 |
| erdnaxeli | so if A and B have each a bridge, the messages sent from A will not be checked on the B bridge and will be display correctly | 21:43:03 |
 kfatehi | makes sense. that check is missing in handleThirdPartyRoomImageMessage | 21:41:33 |
| kfatehi | how are you not getting dupes. maybe im missing something | 21:41:59 |
| erdnaxeli | hmm, good question :D | 21:44:41 |
| kfatehi | lol. ok so i will just move the tag check (+filename checking) into that method and we should be ok | 21:42:56 |
| kfatehi | i mean add, not move | 21:43:26 |
| kfatehi | the solution worked by the way. funny enough :) | 21:43:45 |
| erdnaxeli | ok so here is what happens when I send an image from matrix:
- we send a text message with the filename (tagged): ok, dedup works
- we send the image: it comes back as a
share type, which is not handled for now
| 21:47:37 |
| erdnaxeli | so it's just luck :p | 21:47:46 |
| kfatehi | cool Shmavery just merged my PR adding the link to matrix-puppet-facebook to facebook-chat-api's README | 21:45:26 |
| erdnaxeli | nice o/ | 21:48:11 |
| kfatehi | oh LOL ok got you | 21:45:58 |
| erdnaxeli | on another subject: do you know if an appservice receive the read events? | 21:50:06 |
| erdnaxeli | i've put an info(data) on handleMatrixEvent and I don't see any read event :( | 21:50:53 |
| erdnaxeli | this is not good | 21:50:59 |
| kfatehi | i haven't looked into that yet, sorry | 21:49:06 |
| erdnaxeli | the spec is not really clear about which event are forwarded or not the an appservice | 21:52:10 |
| erdnaxeli | I will just wait for an answer on #bridges:matrix.org | 21:52:45 |
| kfatehi | ha! your solution worked. thanks erdnaxeli | 22:05:50 |
| kfatehi | feels magical. | 22:09:00 |
| kfatehi | going to merge and cutting new releases now. hey does anyone else use the imessage bridge or is it just Andy and I ? | 22:09:26 |
 GoNEB! | [matrix-hacks/matrix-puppet-imessage] kfatehi pushed 3 commits to master: https://github.com/matrix-hacks/matrix-puppet-imessage/commit/2e31124e4a23f0e5e5567bdfc881e93d74c354f6
kfatehi: bidirectional images! dupes when sent from matrix
kfatehi: tag filenames, fix an interface change
kfatehi: bump versions | 22:11:17 |
| GoNEB! | [matrix-hacks/matrix-puppet-bridge] kfatehi pushed to master: add filename tag util, check tags on inbound image - https://github.com/matrix-hacks/matrix-puppet-bridge/commit/4fcc70814989cab00c6175f2d0da94d1de2939ea | 22:12:31 |
| GoNEB! | [matrix-hacks/matrix-puppet-bridge] kfatehi pushed to refs/tags/v1.13.0: add filename tag util, check tags on inbound image - https://github.com/matrix-hacks/matrix-puppet-bridge/commit/4fcc70814989cab00c6175f2d0da94d1de2939ea | 22:12:31 |
| kfatehi | matrix-puppet-bridge v1.13.0 published to npm. major changes are bidirectional image support, and contact list room (as utilized by respective bridge apps) | 22:14:02 |
| kfatehi | another improvement is that more promise-chains are caught into the status room. if anyone notices an error that doesn't go into the status room with a nice error message, make an issue about it because it's a bug. | 22:16:27 |
| GoNEB! | [matrix-hacks/matrix-puppet-bridge] kfatehi closed issue #4: feature: special bridge room with user list [closed] - https://github.com/matrix-hacks/matrix-puppet-bridge/issues/4 | 22:17:24 |
| GoNEB! | [matrix-hacks/matrix-puppet-imessage] kfatehi closed issue #11: Forward images from iMessage->Matrix [closed] - https://github.com/matrix-hacks/matrix-puppet-imessage/issues/11 | 22:17:44 |
