1 May 2024 |
byteit101 | sorry to clarify: I think subspawn fails eagerly today, though with a substandard exception being thrown | 19:51:44 |
headius | I just had to fix another goddamn chdir issue in popen and I don't want to ever do that again | 19:51:48 |
headius | ok | 19:51:53 |
headius | I will play with it and maybe it's basically good enough | 19:52:01 |
headius | if you can sort out a release that has popen in it that will be done | 19:52:24 |
byteit101 | I bet if you manually delete your arch from ffi-binary-* it would be straightforward to test | 19:52:48 |
byteit101 | JK if you are on mac just use 0.5.1.0 | 19:53:49 |
byteit101 | 0.5.1.1 was M1 mac fixes: https://github.com/byteit101/subspawn/commits/lfp-0.5.1.1/ | 19:54:16 |
headius | oh does that pull in the builtin replacements? | 20:01:10 |
byteit101 | 0.5.1.0 had a broken mac build of lfp, so lfp won't load. If you want to test fallback behavior today, you can use that version to see what is thrown | 20:01:57 |
headius | we install this from gems so I would need a release for that, but I can test with a manual copy for now | 20:02:02 |
headius | aha ok | 20:02:06 |
headius | I can update that for sure then | 20:02:10 |
headius | we are aready on binding-lfp 0.5.1.1 | 20:03:42 |
headius | I mean binary | 20:03:46 |
headius | not binding | 20:03:48 |
headius | binding only has 0.5.1.0 currently | 20:04:05 |
headius | it looks like lib/pom.rb is on latest of all the gems | 20:04:18 |
byteit101 | Yes. So if you want to test you can downgrade and it then magically wont have darwin arm64 builds in it to "simulate" not having the right arch | 20:04:20 |
byteit101 | for fallback | 20:04:24 |
headius | ohhh right | 20:04:27 |
headius | I get it | 20:04:28 |
headius | ok | 20:04:31 |
byteit101 | 0.5.1.1 has a darwin arm64 build in it | 20:04:44 |
byteit101 | the other option is to hack your local copy to delete the darwin arm64 build, but I figure changing versions is easier | 20:05:10 |
byteit101 | :-) | 20:05:12 |
byteit101 | That way you can test Process.java (where subspawn is loaded, IIRC) and what exceptions need to be caught | 20:06:57 |
byteit101 | wrong file. Ruby.java: https://github.com/jruby/jruby/blob/c7307300f14745015adebe2f66e8819c7104a0d0/core/src/main/java/org/jruby/Ruby.java#L551 | 20:11:33 |
enebo | yay. I need to clean this up but I fixed a long-standing problem with bindings + dup | 20:29:13 |
enebo | the last two erb specs now pass | 20:29:57 |